linux-kernel - RE: [PATCH] misc: rtsx: init value of aspm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddc599eac41b49ca92b1a0e1936c7dc6@realtek.com>
Date:   Thu, 21 Jan 2021 10:19:50 +0000
From:   吳昊澄 Ricky <ricky_wu@...ltek.com>
To:     "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "vaibhavgupta40@...il.com" <vaibhavgupta40@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] misc: rtsx: init value of aspm_enabled

Abandon this patch
Sorry~

> -----Original Message-----
> From: 吳昊澄 Ricky <ricky_wu@...ltek.com>
> Sent: Thursday, January 21, 2021 6:16 PM
> To: arnd@...db.de; gregkh@...uxfoundation.org; bhelgaas@...gle.com; 吳
> 昊澄 Ricky <ricky_wu@...ltek.com>; vaibhavgupta40@...il.com;
> linux-kernel@...r.kernel.org
> Subject: [PATCH] misc: rtsx: init value of aspm_enabled
> 
> From: Ricky Wu <ricky_wu@...ltek.com>
> 
> make sure ASPM state sync with pcr->aspm_enabled init value
> pcr->aspm_enabled
> 
> Signed-off-by: Ricky Wu <ricky_wu@...ltek.com>
> ---
>  drivers/misc/cardreader/rtsx_pcr.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/cardreader/rtsx_pcr.c
> b/drivers/misc/cardreader/rtsx_pcr.c
> index 2aa6648fa41f..06df0687c0bb 100644
> --- a/drivers/misc/cardreader/rtsx_pcr.c
> +++ b/drivers/misc/cardreader/rtsx_pcr.c
> @@ -1512,6 +1512,7 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
>  	struct pcr_handle *handle;
>  	u32 base, len;
>  	int ret, i, bar = 0;
> +	u8 val;
> 
>  	dev_dbg(&(pcidev->dev),
>  		": Realtek PCI-E Card Reader found at %s [%04x:%04x] (rev %x)\n",
> @@ -1577,7 +1578,11 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
>  	pcr->host_cmds_addr = pcr->rtsx_resv_buf_addr;
>  	pcr->host_sg_tbl_ptr = pcr->rtsx_resv_buf + HOST_CMDS_BUF_LEN;
>  	pcr->host_sg_tbl_addr = pcr->rtsx_resv_buf_addr +
> HOST_CMDS_BUF_LEN;
> -
> +	rtsx_pci_read_register(pcr, ASPM_FORCE_CTL, &val);
> +	if (val & FORCE_ASPM_CTL0 || val & FORCE_ASPM_CTL1)
> +		pcr->aspm_enabled = true;
> +	else
> +		pcr->aspm_enabled = false;
>  	pcr->card_inserted = 0;
>  	pcr->card_removed = 0;
>  	INIT_DELAYED_WORK(&pcr->carddet_work, rtsx_pci_card_detect);
> --
> 2.17.1