linux-kernel - Re: [TEST PATCH v1] driver: core: Make fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80832719-85dc-c6ba-a7e9-5d53f4020e52@samsung.com>
Date:   Thu, 21 Jan 2021 11:33:39 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Saravana Kannan <saravanak@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Marc Zyngier <maz@...nel.org>, kernel-team@...roid.com,
        linux-kernel@...r.kernel.org
Subject: Re: [TEST PATCH v1] driver: core: Make fw_devlink=on more forgiving

Hi Saravana,

On 21.01.2021 09:22, Saravana Kannan wrote:
> This patch is for test purposes only and pretty experimental. Code might
> not be optimized, clean, formatted properly, etc.
>
> Please review it only for functional bugs like locking bugs, wrong
> logic, etc.
>
> It's basically trying to figure out which devices will never probe and
> ignore them. Might not always work.
>
> Marek, Geert, Marc,
>
> Can you please try this patch INSTEAD of the other workarounds we found?

I've checked the latest linux-next with this patch and commit 
c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform 
driver") reverted. Sadly it doesn't help. All devices that belongs to 
the Exynos power domains are not probed at all ("supplier 
10023cXX.power-domain not ready").

> Jon, Michael,
>
> I'm explicitly not including you in the "To" because this patch won't
> work for your issues.
>
> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Marc Zyngier <maz@...nel.org>
> Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> ---
>   drivers/base/base.h |   3 ++
>   drivers/base/core.c | 117 +++++++++++++++++++++++++++++++++++++++++++-
>   drivers/base/dd.c   |  24 +++++++++
>   3 files changed, 142 insertions(+), 2 deletions(-)
>
> > [...]

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland