linux-kernel - Re: [PATCH 1/1] spi: atmel: Put allocated master before return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <812b9c86-22fc-f59d-7f31-cfea4c07f708@microchip.com>
Date:   Thu, 21 Jan 2021 12:00:25 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <bianpan2016@....com>, <broonie@...nel.org>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <cyrille.pitchen@...el.com>
CC:     <linux-spi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] spi: atmel: Put allocated master before return

On 1/20/21 7:00 AM, Pan Bian wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The allocated master is not released. Goto error handling label rather
> than directly return.
> 
> Fixes: 04242ca4e891 ("spi: atmel: Use SPI core DMA mapping framework")
The correct fixes tag is:
Fixes: 5e9af37e46bc ("spi: atmel: introduce probe deferring")

With this addressed, one can add:
Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

> Signed-off-by: Pan Bian <bianpan2016@....com>
> ---
>  drivers/spi/spi-atmel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 948396b382d7..f429436082af 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -1590,7 +1590,7 @@ static int atmel_spi_probe(struct platform_device *pdev)
>                 if (ret == 0) {
>                         as->use_dma = true;
>                 } else if (ret == -EPROBE_DEFER) {
> -                       return ret;
> +                       goto out_unmap_regs;
>                 }
>         } else if (as->caps.has_pdc_support) {
>                 as->use_pdc = true;
> --
> 2.17.1
> 
>