linux-kernel - Re: [PATCH] USB: serial: cp210x: suppress modem-control error on open and close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jan 2021 11:32:10 +0100
From:   Johan Hovold <johan@...nel.org>
To:     linux-usb@...r.kernel.org
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        linux-kernel@...r.kernel.org, Johan Hovold <johan@...nel.org>,
        Pho Tran <pho.tran@...abs.com>
Subject: Re: [PATCH] USB: serial: cp210x: suppress modem-control error on
 open and close

On Thu, Jan 21, 2021 at 11:29:12AM +0100, Johan Hovold wrote:
> The CP210X_SET_MHS request cannot be used to control DTR/RTS when
> hardware flow control is enabled and instead returns an error which is
> currently logged as:
> 
> 	cp210x ttyUSB0: failed set request 0x7 status: -32
> 
> Add a crtscts flag to keep track of the hardware flow-control setting
> and use it to suppress the request in dtr_rts().
> 
> Note that both lines are still deasserted when disabling the UART as
> part of close().
> 
> Also note that TIOCMSET is left unchanged and will continue to return an
> error to user-space when flow control is enabled (i.e. instead of
> disabling and re-enabling auto-RTS when RTS is deasserted and
> re-asserted).
> 
> Reported-by: Pho Tran <pho.tran@...abs.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---

Oops, this one wasn't supposed to be submitted again. Please ignore.

Johan