linux-kernel - Re: [PATCH] perf evlist: Fix id index for heterogeneous systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210121134018.GC12699@kernel.org>
Date:   Thu, 21 Jan 2021 10:40:18 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org,
        Jin Yao <yao.jin@...ux.intel.com>
Subject: Re: [PATCH] perf evlist: Fix id index for heterogeneous systems

Em Thu, Jan 21, 2021 at 03:39:03PM +0200, Adrian Hunter escreveu:
> On 21/01/21 3:19 pm, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jan 21, 2021 at 02:54:46PM +0200, Adrian Hunter escreveu:
> >> perf_evlist__set_sid_idx() updates perf_sample_id with the evlist map
> >> index, cpu number and tid. It is passed indexes to the evsel's cpu and
> >> thread maps, but references the evlist's maps instead. That results in
> >> using incorrect cpu numbers on heterogeneous systems. Fix by using evsel
> >> maps.
> >>
> >> The id index (PERF_RECORD_ID_INDEX) is used by AUX area tracing when in
> >> sampling mode. Having an incorrect cpu number causes the trace data to
> >> be attributed to the wrong cpu, and can result in decoder errors because
> >> the trace data is then associated with the wrong process.
> > 
> > Can you please provide a Fixes: tag so that the stable@...nel.org guys
> > can apply where appropriate?
> 
> Oops sorry missed that.  Here it is:
> 
> Fixes: 3c659eedada2 ("perf tools: Add id index")


Thanks a lot!

- Arnaldo