lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <3044193d-1610-fd67-e4ec-12a87fed62f2@redhat.com> Date: Thu, 21 Jan 2021 15:23:13 +0100 From: Paolo Bonzini <pbonzini@...hat.com> To: Maxim Levitsky <mlevitsk@...hat.com>, Wei Huang <wei.huang2@....com>, kvm@...r.kernel.org Cc: linux-kernel@...r.kernel.org, vkuznets@...hat.com, seanjc@...gle.com, joro@...tes.org, bp@...en8.de, tglx@...utronix.de, mingo@...hat.com, x86@...nel.org, jmattson@...gle.com, wanpengli@...cent.com, bsd@...hat.com, dgilbert@...hat.com, luto@...capital.net Subject: Re: [PATCH v2 1/4] KVM: x86: Factor out x86 instruction emulation with decoding On 21/01/21 15:04, Maxim Levitsky wrote: >> +int x86_emulate_decoded_instruction(struct kvm_vcpu *vcpu, int emulation_type, >> + void *insn, int insn_len) > Isn't the name of this function wrong? This function decodes the instruction. > So I would expect something like x86_decode_instruction. > Yes, that or x86_decode_emulated_instruction. Paolo
Powered by blists - more mailing lists