linux-kernel - Re: [RFC PATCH 1/2] soundwire: add support for static port mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e962caa8-89c3-4a22-5932-4498c406e8f8@linaro.org>
Date:   Fri, 22 Jan 2021 15:46:15 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        vkoul@...nel.org, yung-chuan.liao@...ux.intel.com
Cc:     gregkh@...uxfoundation.org, sanyog.r.kale@...el.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] soundwire: add support for static port mapping



On 22/01/2021 15:32, Pierre-Louis Bossart wrote:
>>
>> Are you suggesting that we have dailink for each usecase like:
>>
>> "headset capture"
>> "Analog MIC1 capture"
>> "Analog MIC2 Capture"
>>
>> ...
>>
>> "Analog MIC4 Capture"
>>
>> ...
>>
>> "DMIC0 capture"
>> "DMIC1 Capture"
>> "DMIC2 Capture"
>>
>> ...
>>
>> "DMIC7 Capture"
>> ..
>> "Headset Playback"
>> "Ear Playback"
>> ..
>> "Aux Playback"
>> ...
>>
>> this is not really doable!
> 
> No, what I was saying is that you need to define multiple streams e.g.
> - headset capture (configured with or without click suppression)
> - mic capture (configured with AMICs or DMICs)
> - playback (or possibly different endpoint specific streams depending on 
> whether concurrency between endpoint is possible)
> 
> if you change the configuration, you have to tear down the stream and 
> reconfigure it - and for this we already have the required API and you 
> can guarantee that the configuration for that stream is consistent 
> between master and slave(s).

Yes, we make sure that new configuration is only applied before the 
stream is started, and not in middle of already started stream.
> 
>> All am saying is that codec can decide which ports it has to select 
>> based on mixer setting before the stream is setup/started. This 
>> updated mapping between slv port and master ports is passed as part of 
>> the port_config in sdw_stream_add_slave().
> 
> if you completely remove the stream and re-add it with updated 
> configuration things should work.

That's exactly what we do currently!

The updated ports due to new configuration ex: for "mic capture" dailink 
needs to be communicated from slave(codec) to master so that it can 
allocate correct ports. That is what this patch is trying to do (share 
current port map information).

--srini