linux-kernel - Re: [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e9dbb21-bcf5-4a9e-3729-405813ecabd3@infradead.org>
Date:   Fri, 22 Jan 2021 09:38:41 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Theodore Ts'o <tytso@....edu>,
        Andreas Dilger <adilger.kernel@...ger.ca>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Iurii Zaikin <yzaikin@...gle.com>
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS
 instead of selecting it

On 1/22/21 3:02 AM, Geert Uytterhoeven wrote:
> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the
> user may not want to enable.  Fix this by making the test depend on
> EXT4_FS instead.
> 
> Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
> Discussion after previous submission at
> https://lore.kernel.org/linux-ext4/20201020073740.29081-1-geert@linux-m68k.org/
> ---
>  fs/ext4/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index 619dd35ddd48a973..86699c8cab281cbc 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -103,8 +103,7 @@ config EXT4_DEBUG
>  
>  config EXT4_KUNIT_TESTS
>  	tristate "KUnit tests for ext4" if !KUNIT_ALL_TESTS
> -	select EXT4_FS
> -	depends on KUNIT
> +	depends on EXT4_FS && KUNIT
>  	default KUNIT_ALL_TESTS
>  	help
>  	  This builds the ext4 KUnit tests.
> 


-- 
~Randy