linux-kernel - Re: [PATCH] mm: Optimizing error condition detection in do_mprotect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YAsNja81xnhvRGsL@kernel.org>
Date:   Fri, 22 Jan 2021 19:38:21 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, Shuah Khan <shuah@...nel.org>,
        haitao.huang@...el.com, Kai Huang <kai.huang@...el.com>,
        x86@...nel.org, linux-sgx@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org,
        Jia Zhang <zhang.jia@...ux.alibaba.com>
Subject: Re: [PATCH] mm: Optimizing error condition detection in
 do_mprotect_pkey()

On Thu, Jan 21, 2021 at 02:46:27PM -0800, Andrew Morton wrote:
> On Wed, 20 Jan 2021 16:29:20 +0200 Jarkko Sakkinen <jarkko@...nel.org> wrote:
> 
> > 
> > 
> > On Mon, Jan 18, 2021 at 09:33:10PM +0800, Tianjia Zhang wrote:
> > > Obviously, the error variable detection of the if statement is
> > > for the mprotect callback function, so it is also put into the
> > > scope of calling callbck.
> > > 
> > > Reported-by: Jia Zhang <zhang.jia@...ux.alibaba.com>
> > > Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> > 
> > No fixes tag, no description what this commit does. Nothing
> > makes sense to me.
> 
> It's a little cleanup.  Makes the flow at this site consistent with the
> other places where this function handles errors.  I added a bit to the
> changelog mentioning this.

Alright, I see. I'm just used to getting feedback to my own patches
that "imperative form" of expression should be rigidly used. That's the
main reason I gave the feedback.

/Jarkko