linux-kernel - Re: [PATCH] cpupower: add Makefile dependencies for install targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <356b4879-f633-44fc-59ad-69be6c2f9a92@linuxfoundation.org>
Date:   Fri, 22 Jan 2021 11:02:55 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Thomas Renninger <trenn@...e.com>,
        Ivan Babrou <ivan@...udflare.com>
Cc:     linux-pm@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        kernel-team <kernel-team@...udflare.com>,
        Shuah Khan <shuah@...nel.org>, rafael@...nel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] cpupower: add Makefile dependencies for install targets

On 1/7/21 2:29 PM, Thomas Renninger wrote:
> Am Donnerstag, 7. Januar 2021, 22:15:16 CET schrieb Ivan Babrou:
>> On Thu, Jan 7, 2021 at 12:59 PM Thomas Renninger <trenn@...e.com> wrote:
>>> Am Donnerstag, 7. Januar 2021, 18:42:25 CET schrieb Ivan Babrou:
>>>> On Thu, Jan 7, 2021 at 2:07 AM Thomas Renninger <trenn@...e.com> wrote:
>>>>> Am Dienstag, 5. Januar 2021, 00:57:18 CET schrieb Ivan Babrou:
>>>>>> This allows building cpupower in parallel rather than serially.
> ...
>>> Can you please show the make calls, ideally with a timing to better
>>> understand and also to reproduce the advantages this patch introduces.
>>>  From what I can see, it only helps if one calls "sub-install" targets
>>> directly?
>>
>> That's exactly what we do: make install directly:
>>
>> /linux-5.10.5$ make -C ./tools/power/cpupower DESTDIR=/tmp/cpupower
>> install -j $(nproc)
> 
> This makes sense then.
> @Shuah @Rafael: Can this patch be queued up, please.
> 
> Thanks for the patch and the details,
> 

Thank you both.

I applied it 
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git/commit/?h=cpupower

Will send this in my next pull request to Rafael.

thanks,
-- Shuah