[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bef54bf0-7c9e-09ce-9f37-ab9498959ba1@infradead.org>
Date: Fri, 22 Jan 2021 09:23:10 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Andrew Jeffery <andrew@...id.au>, linux-mmc@...r.kernel.org
Cc: adrian.hunter@...el.com, ulf.hansson@...aro.org, joel@....id.au,
linux-aspeed@...ts.ozlabs.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
brendanhiggins@...gle.com
Subject: Re: [PATCH v2] mmc: sdhci-of-aspeed: Fix kunit-related build error
On 1/22/21 3:48 AM, Andrew Jeffery wrote:
> Randy found that with the following Kconfig settings we have duplicate
> definitions (e.g. __inittest()) in sdhci-of-aspeed due to competing
> module_init()/module_exit() calls from kunit and driver the itself.
>
> ```
> CONFIG_MMC_SDHCI_OF_ASPEED=m
> CONFIG_MMC_SDHCI_OF_ASPEED_TEST=y
> ```
>
> Conditionally open-code the kunit initialisation to avoid the error.
>
> Fixes: 7efa02a981d6 ("mmc: sdhci-of-aspeed: Add KUnit tests for phase calculations")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Andrew Jeffery <andrew@...id.au>
> ---
>
> v2:
> * Collapse the #ifdef-ery
>
> drivers/mmc/host/sdhci-of-aspeed-test.c | 9 +++++-
> drivers/mmc/host/sdhci-of-aspeed.c | 42 ++++++++++++++++++++++---
> 2 files changed, 45 insertions(+), 6 deletions(-)
Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
Thanks.
--
~Randy
Powered by blists - more mailing lists