linux-kernel - Re: [PATCH v5 0/5] mm: clean up names and parameters of memmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210122181209.GD6332@kernel.org>
Date:   Fri, 22 Jan 2021 20:12:09 +0200
From:   Mike Rapoport <rppt@...nel.org>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        akpm@...ux-foundation.org, david@...hat.com, lkp@...el.com
Subject: Re: [PATCH v5 0/5] mm: clean up names and parameters of
 memmap_init_xxxx functions

On Fri, Jan 22, 2021 at 09:59:51PM +0800, Baoquan He wrote:
> This patchset is correcting inappropriate function names of
> memmap_init_xxx, and simplify parameters of functions in the code flow.
> And also fix a prototype warning reported by lkp.
> 
> This is based on the latest next/master.
> 
> V4 can be found here:
> https://lore.kernel.org/linux-mm/20210120045213.6571-1-bhe@redhat.com/
> 
> v4->v5:
>  - Add patch 1 into series which fixes a prototype warning from kernel
>    test robot. Then rebase the v4 patches on top of it.
> 
> v3->v4:
>  - Rebased patch 1, 2 on top of Mike's below new patch.
>    [PATCH v3 0/2] mm: fix initialization of struct page for holes in  memory layout
> 
>  - Move the code of renaming function parameter 'range_start_pfn' and local
>    variable 'range_end_pfn' of memmap_init() from patch 1 to patch 2
>    according to David's comment.
> 
>  - Use the reverse Christmas tree style to reorder the local variables
>    in memmap_init_zone() in patch 2 accodrding to David's comment.
> 
> Baoquan He (5):
>   mm: fix prototype warning from kernel test robot
>   mm: rename memmap_init() and memmap_init_zone()
>   mm: simplify parater of function memmap_init_zone()
>   mm: simplify parameter of setup_usemap()
>   mm: remove unneeded local variable in free_area_init_core

For the series:

Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>

> 
>  arch/ia64/include/asm/pgtable.h |  6 -----
>  arch/ia64/mm/init.c             | 14 +++++-----
>  include/linux/mm.h              |  3 ++-
>  mm/memory_hotplug.c             |  2 +-
>  mm/page_alloc.c                 | 46 ++++++++++++++-------------------
>  5 files changed, 31 insertions(+), 40 deletions(-)
> 
> -- 
> 2.17.2
> 

-- 
Sincerely yours,
Mike.