linux-kernel - Re: [PATCH v3 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63f62136-8d19-c281-bbae-3e1e6b0fd4e3@redhat.com>
Date:   Fri, 22 Jan 2021 22:17:14 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>, patches@...nsource.cirrus.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>
Subject: Re: [PATCH v3 06/13] ASoC/extcon: arizona: Move arizona jack code to
 sound/soc/codecs/arizona-jack.c

Hi,

On 1/22/21 9:40 PM, Andy Shevchenko wrote:
> On Fri, Jan 22, 2021 at 6:41 PM Hans de Goede <hdegoede@...hat.com> wrote:
>>
>> The jack handling for arizona codecs is being refactored so that it is
>> done directly by the codec drivers, instead of having an extcon-driver
>> bind to a separate "arizona-extcon" child-device for this.
>>
>> drivers/mfd/arizona-core.c has already been updated to no longer
>> instantiate an "arizona-extcon" child-device for the arizona codecs.
>>
>> This means that the "arizona-extcon" driver is no longer useful
>> (there are no longer any devices for it to bind to).
>>
>> This commit drops the extcon Kconfig / Makefile bits and moves
>> drivers/extcon/extcon-arizona.c to sound/soc/codecs/arizona-jack.c .
>>
>> This is a preparation patch for converting the arizona extcon-driver into
>> a helper library for letting the arizona codec-drivers directly report jack
>> state through the standard sound/soc/soc-jack.c functions.
> 
> ...
> 
>>  MAINTAINERS                                               | 1 -
> 
>> -F:     drivers/extcon/extcon-arizona.c
> 
> Commit message doesn't shed a light if we need to move this actually
> to another record in MAINTAINERS database.

Ah, good call, yes we should. I'll fix this for v4.

Regards,

Hans