linux-kernel - Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecc54ce2-cbda-d801-1127-e1c15aa22654@gmail.com>
Date:   Fri, 22 Jan 2021 13:52:48 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Sergej Bauer <sbauer@...ckbox.su>, netdev@...r.kernel.org
Cc:     andrew@...n.ch, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Bryan Whitehead <bryan.whitehead@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Simon Horman <simon.horman@...ronome.com>,
        Mark Einon <mark.einon@...il.com>,
        Madalin Bucur <madalin.bucur@....nxp.com>,
        Arnd Bergmann <arnd@...db.de>,
        Masahiro Yamada <masahiroy@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices



On 1/22/2021 1:42 PM, Sergej Bauer wrote:
> From: sbauer@...ckbox.su
> 
> v1->v2:
> 	switch to using of fixed_phy as was suggested by Andrew and Florian
> 	also features-related parts are removed
> 
> Previous versions can be found at:
> v1:
> initial version
> 	https://lkml.org/lkml/2020/9/17/1272
> 
> Signed-off-by: Sergej Bauer <sbauer@...ckbox.su>

You are not explaining why you need this and why you are second guessing
the fixed PHY MII emulation that already exists. You really need to do a
better job at describing your changes and why the emulation offered by
swphy.c is not enough for your use case.
-- 
Florian