linux-kernel - Re: [PATCH v1] memory: tegra: Check whether reset is already asserted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210122231950.znm7s3zukn63q46m@kozik-lap>
Date:   Sat, 23 Jan 2021 00:19:50 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Peter Geis <pgwipeout@...il.com>,
        Nicolas Chauvet <kwizart@...il.com>,
        Matt Merhar <mattmerhar@...tonmail.com>,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] memory: tegra: Check whether reset is already asserted

On Sat, Jan 23, 2021 at 12:58:12AM +0300, Dmitry Osipenko wrote:
> 23.01.2021 00:40, Krzysztof Kozlowski пишет:
> > On Wed, Jan 20, 2021 at 02:52:10AM +0300, Dmitry Osipenko wrote:
> >> Check whether memory client reset is already asserted in order to prevent
> >> DMA-flush error on trying to re-assert an already asserted reset.
> >>
> >> This becomes a problem once PMC GENPD is enabled to use memory resets
> >> since GENPD will get a error and fail to toggle power domain. PMC GENPDs
> >> can't be toggled safely without holding memory reset on Tegra and we're
> >> about to fix this.
> >>
> >> Tested-by: Peter Geis <pgwipeout@...il.com> # Ouya T30
> >> Tested-by: Dmitry Osipenko <digetx@...il.com> # A500 T20 and Nexus7 T30
> > 
> > Don't add your own Tested-by. Author has to test it.  However this is a
> > v1 and already three other people added tests. Where are the emails?
> 
> The test results were given on #tegra irc.
> 
> Author doesn't have to test, from time to time I'm helping people who
> can't make a patch with fixing obvious bugs for the h/w that I don't
> have access to.

By default, author's patches are assumed to be tested, otherwise we
would be putting own Tested-by in most of the cases (ideally: in all).
Just because you do not see author's Tested-by everywhere it does not
mean that author did not test it...

Testing is also a requirement:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/5.Posting.rst#L35

Therefore if your non-trivial patches are not tested, please also
mention it with RFT or after '---'.

> 
> Anyways, I'll make v2 with myself removed if you prefer that, thanks.

I applied it without your tested-by. If the tested platform is anyhow
relevant, just mention it in the commit msg.

Best regards,
Krzysztof