linux-kernel - RE: [PATCH v2 1/3] perf vendor events: Add cache refill and DCZVA events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OSBPR01MB4600DCC22FFE8BA6A6BB2897F7A00@OSBPR01MB4600.jpnprd01.prod.outlook.com>
Date:   Fri, 22 Jan 2021 08:35:52 +0000
From:   "nakamura.shun@...itsu.com" <nakamura.shun@...itsu.com>
To:     'John Garry' <john.garry@...wei.com>,
        Shaokun Zhang <zhangshaokun@...ilicon.com>
CC:     "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "leo.yan@...aro.org" <leo.yan@...aro.org>,
        "will@...nel.org" <will@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 1/3] perf vendor events: Add cache refill and DCZVA
 events

Hi,  John, Shaokun

> > 在 2021/1/21 18:54, Shunsuke Nakamura 写道:
> >> Adds L1 data cache refill prefetch, L2 data cache refill prefetch,
> >> and DCZVA instruction events.
> >
> > A silly question, Does Arm define these events? I checked Arm ARM
> > document(DDI0487Fc) that these event numbers are reserved. Or maybe I
> > miss something.
> 
> For events which are reserved (see k3-1), like 0x9f, prob should not be putting in
> this file, but rather the CPU JSON.

I missed the reservation area for ARM recommended events.
I will fix the patch as you pointed out.

Best Regards

> -----Original Message-----
> From: John Garry <john.garry@...wei.com>
> Sent: Friday, January 22, 2021 2:44 AM
> To: Shaokun Zhang <zhangshaokun@...ilicon.com>; Nakamura, Shunsuke/中村
> 俊介 <nakamura.shun@...itsu.com>
> Cc: mathieu.poirier@...aro.org; linux-kernel@...r.kernel.org;
> leo.yan@...aro.org; will@...nel.org; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v2 1/3] perf vendor events: Add cache refill and DCZVA
> events
> 
> On 21/01/2021 11:39, Shaokun Zhang wrote:
> > Hi,
> >
> > 在 2021/1/21 18:54, Shunsuke Nakamura 写道:
> >> Adds L1 data cache refill prefetch, L2 data cache refill prefetch,
> >> and DCZVA instruction events.
> >
> > A silly question, Does Arm define these events? I checked Arm ARM
> > document(DDI0487Fc) that these event numbers are reserved. Or maybe I
> > miss something.
> 
> For events which are reserved (see k3-1), like 0x9f, prob should not be putting in
> this file, but rather the CPU JSON.
> 
> Cheers,
> John
> 
> >
> >>
> >> Signed-off-by: Shunsuke Nakamura <nakamura.shun@...fujitsu.com>
> >> ---
> >>   .../perf/pmu-events/arch/arm64/armv8-recommended.json  | 18
> ++++++++++++++++++
> >>   1 file changed, 18 insertions(+)
> >>
> >> diff --git a/tools/perf/pmu-events/arch/arm64/armv8-recommended.json
> >> b/tools/perf/pmu-events/arch/arm64/armv8-recommended.json
> >> index d0a1986..ee0e67d 100644
> >> --- a/tools/perf/pmu-events/arch/arm64/armv8-recommended.json
> >> +++ b/tools/perf/pmu-events/arch/arm64/armv8-recommended.json
> >> @@ -54,6 +54,12 @@
> >>           "BriefDescription": "L1D cache invalidate"
> >>       },
> >>       {
> >> +        "PublicDescription": "This event counts L1D_CACHE_REFILL
> caused by software or hardware prefetch.",
> >> +        "EventCode": "0x49",
> >> +        "EventName": "L1D_CACHE_REFILL_PRF",
> >> +        "BriefDescription": "This event counts L1D_CACHE_REFILL caused
> by software or hardware prefetch."
> >> +    },
> >> +    {
> >>           "PublicDescription": "Attributable Level 1 data TLB refill, read",
> >>           "EventCode": "0x4C",
> >>           "EventName": "L1D_TLB_REFILL_RD", @@ -120,6 +126,12 @@
> >>           "BriefDescription": "L2D cache invalidate"
> >>       },
> >>       {
> >> +        "PublicDescription": "This event counts L2D_CACHE_REFILL
> caused by software or hardware prefetch.",
> >> +        "EventCode": "0x59",
> >> +        "EventName": "L2D_CACHE_REFILL_PRF",
> >> +        "BriefDescription": "This event counts L2D_CACHE_REFILL caused
> by software or hardware prefetch."
> >> +    },
> >> +    {
> >>           "PublicDescription": "Attributable Level 2 data or unified TLB refill,
> read",
> >>           "EventCode": "0x5c",
> >>           "EventName": "L2D_TLB_REFILL_RD", @@ -408,6 +420,12 @@
> >>           "BriefDescription": "Release consistency operation speculatively
> executed, Store-Release"
> >>      },
> >>      {
> >> +         "PublicDescription": "This event counts architecturally executed
> zero blocking operations due to the 'DC ZVA' instruction.",
> >> +         "EventCode": "0x9f",
> >> +         "EventName": "DCZVA_SPEC",
> >> +         "BriefDescription": "This event counts architecturally executed
> zero blocking operations due to the 'DC ZVA' instruction."
> >> +   },
> >> +   {
> >>           "PublicDescription": "Attributable Level 3 data or unified cache
> access, read",
> >>           "EventCode": "0xa0",
> >>           "EventName": "L3D_CACHE_RD",
> >>
> > .
> >