linux-kernel - Re: [PATCH v3] i2c: ismt: Use dma_set_mask_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210122090737.GG858@kunai>
Date:   Fri, 22 Jan 2021 10:07:37 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Youling Tang <tangyouling@...ngson.cn>
Cc:     Seth Heasley <seth.heasley@...el.com>,
        Neil Horman <nhorman@...driver.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c: ismt: Use dma_set_mask_and_coherent

On Thu, Dec 03, 2020 at 02:50:52PM +0800, Youling Tang wrote:
> 'pci_set_dma_mask()' + 'pci_set_consistent_dma_mask()' can be replaced by
> an equivalent 'dma_set_mask_and_coherent()' which is much less verbose.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Youling Tang <tangyouling@...ngson.cn>

Seth, Neil, are you OK with this patch?

> ---
> 
> v3: Fix build errors of incompatible pointer types.
> 
>  drivers/i2c/busses/i2c-ismt.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ismt.c b/drivers/i2c/busses/i2c-ismt.c
> index a35a27c..88f6039 100644
> --- a/drivers/i2c/busses/i2c-ismt.c
> +++ b/drivers/i2c/busses/i2c-ismt.c
> @@ -903,16 +903,12 @@ ismt_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  		return -ENODEV;
>  	}
>  
> -	if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(64)) != 0) ||
> -	    (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)) != 0)) {
> -		if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)) != 0) ||
> -		    (pci_set_consistent_dma_mask(pdev,
> -						 DMA_BIT_MASK(32)) != 0)) {
> -			dev_err(&pdev->dev, "pci_set_dma_mask fail %p\n",
> +	if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)) != 0)
> +		if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)) != 0) {
> +			dev_err(&pdev->dev, "dma_set_mask_and_coherent fail %p\n",
>  				pdev);
>  			return -ENODEV;
>  		}
> -	}
>  
>  	err = ismt_dev_init(priv);
>  	if (err)
> -- 
> 2.1.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)