linux-kernel - Re: [PATCH v5 4/6] arm64: mte: Enable async tag check fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04eba2be-641b-ee23-7fa0-436c33168cd8@arm.com>
Date:   Fri, 22 Jan 2021 11:24:28 +0000
From:   Vincenzo Frascino <vincenzo.frascino@....com>
To:     Andrey Konovalov <andreyknvl@...gle.com>
Cc:     Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Marco Elver <elver@...gle.com>,
        Evgenii Stepanov <eugenis@...gle.com>,
        Branislav Rankov <Branislav.Rankov@....com>
Subject: Re: [PATCH v5 4/6] arm64: mte: Enable async tag check fault



On 1/21/21 5:38 PM, Andrey Konovalov wrote:
>> +       if (unlikely(tfsr_el1 & SYS_TFSR_EL1_TF1)) {
>> +               /*
>> +                * Note: isb() is not required after this direct write
>> +                * because there is no indirect read subsequent to it
>> +                * (per ARM DDI 0487F.c table D13-1).
>> +                */
>> +               write_sysreg_s(0, SYS_TFSR_EL1);
>> +
>> +               kasan_report_async();
> Do we need a static bool reported like in do_tag_recovery() here?
> 

I would say not because async mode does not get disabled after the first fault.

-- 
Regards,
Vincenzo