linux-kernel - Re: [PATCH] uacce: Add uacce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YAq5S2RAQV25+iaG@kroah.com>
Date:   Fri, 22 Jan 2021 12:38:51 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Zhou Wang <wangzhou1@...ilicon.com>
Cc:     Zhangfei Gao <zhangfei.gao@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        linux-accelerators@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        Sihang Chen <chensihang1@...ilicon.com>
Subject: Re: [PATCH] uacce: Add uacce_ctrl misc device

On Fri, Jan 22, 2021 at 07:33:40PM +0800, Zhou Wang wrote:
> >> +struct uacce_pin_address {
> >> +	unsigned long addr;
> >> +	unsigned long size;
> > 
> > These are not valid ioctl structure members for crossing the user/kernel
> > boundry.  Please make them work properly (i.e. use __u64 and friends).
> 
> Got it, will modify this to __u64 together with other problems found by 0-day robot.

Please also properly involve the mm and dma developers and, again,
consider just making this a syscall instead of an ioctl.

thanks,

greg k-h