linux-kernel - [PATCH] ata: sata_nv: remove h from printk format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 22 Jan 2021 06:35:21 -0800
From:   trix@...hat.com
To:     axboe@...nel.dk
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tom Rix <trix@...hat.com>
Subject: [PATCH] ata: sata_nv: remove h from printk format specifier

From: Tom Rix <trix@...hat.com>

This change fixes the checkpatch warning described in this commit
commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
  unnecessary %h[xudi] and %hh[xudi]")

Standard integer promotion is already done and %hx and %hhx is useless
so do not encourage the use of %hh[xudi] or %h[xudi].

Signed-off-by: Tom Rix <trix@...hat.com>
---
 drivers/ata/sata_nv.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 20190f66ced9..81b75e513266 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -603,7 +603,7 @@ static void nv_adma_register_mode(struct ata_port *ap)
 		count++;
 	}
 	if (count == 20)
-		ata_port_warn(ap, "timeout waiting for ADMA IDLE, stat=0x%hx\n",
+		ata_port_warn(ap, "timeout waiting for ADMA IDLE, stat=0x%x\n",
 			      status);
 
 	tmp = readw(mmio + NV_ADMA_CTL);
@@ -618,7 +618,7 @@ static void nv_adma_register_mode(struct ata_port *ap)
 	}
 	if (count == 20)
 		ata_port_warn(ap,
-			      "timeout waiting for ADMA LEGACY, stat=0x%hx\n",
+			      "timeout waiting for ADMA LEGACY, stat=0x%x\n",
 			      status);
 
 	pp->flags |= NV_ADMA_PORT_REGISTER_MODE;
@@ -648,7 +648,7 @@ static void nv_adma_mode(struct ata_port *ap)
 	}
 	if (count == 20)
 		ata_port_warn(ap,
-			"timeout waiting for ADMA LEGACY clear and IDLE, stat=0x%hx\n",
+			"timeout waiting for ADMA LEGACY clear and IDLE, stat=0x%x\n",
 			status);
 
 	pp->flags &= ~NV_ADMA_PORT_REGISTER_MODE;
@@ -736,7 +736,7 @@ static int nv_adma_slave_config(struct scsi_device *sdev)
 	blk_queue_segment_boundary(sdev->request_queue, segment_boundary);
 	blk_queue_max_segments(sdev->request_queue, sg_tablesize);
 	ata_port_info(ap,
-		      "DMA mask 0x%llX, segment boundary 0x%lX, hw segs %hu\n",
+		      "DMA mask 0x%llX, segment boundary 0x%lX, hw segs %u\n",
 		      (unsigned long long)*ap->host->dev->dma_mask,
 		      segment_boundary, sg_tablesize);
 
-- 
2.27.0