linux-kernel - Re: [PATCH] PNP: add printf attribute to log function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iUVf_5QFKWJBQwy41CK=+FShUxWK05L_2ANqiFRKvfZA@mail.gmail.com>
Date:   Fri, 22 Jan 2021 16:21:39 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Tom Rix <trix@...hat.com>
Cc:     Rafael Wysocki <rafael.j.wysocki@...el.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PNP: add printf attribute to log function

On Mon, Dec 21, 2020 at 5:04 PM <trix@...hat.com> wrote:
>
> From: Tom Rix <trix@...hat.com>
>
> Attributing the function allows the compiler to more thoroughly
> check the use of the function with -Wformat and similar flags.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/pnp/interface.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pnp/interface.c b/drivers/pnp/interface.c
> index 187e4a1175b0..602c46893e83 100644
> --- a/drivers/pnp/interface.c
> +++ b/drivers/pnp/interface.c
> @@ -33,6 +33,7 @@ struct pnp_info_buffer {
>
>  typedef struct pnp_info_buffer pnp_info_buffer_t;
>
> +__printf(2, 3)
>  static int pnp_printf(pnp_info_buffer_t * buffer, char *fmt, ...)
>  {
>         va_list args;
> --

Applied as 5.12 material, thanks!