lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <36d0dad5-d5dd-a089-b65b-0d476e639a98@gmail.com>
Date:   Fri, 22 Jan 2021 19:00:32 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Peter Geis <pgwipeout@...il.com>,
        Nicolas Chauvet <kwizart@...il.com>,
        Matt Merhar <mattmerhar@...tonmail.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v3] regulator: Make regulator_sync_voltage() usable by
 coupled regulators

22.01.2021 16:40, Mark Brown пишет:
> On Fri, Jan 22, 2021 at 01:16:49AM +0300, Dmitry Osipenko wrote:
> 
>> +	/* balance only if there are regulators coupled */
>> +	if (rdev->coupling_desc.n_coupled > 1) {
>> +		ret = regulator_balance_voltage(rdev, PM_SUSPEND_ON);
>> +		goto out;
>> +	}
>> +
>>  	ret = _regulator_do_set_voltage(rdev, min_uV, max_uV);
>>  
>>  out:
> 
> This would be clearer written as an if/else rather than using the goto.
> 

I'll make v4, thanks.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ