linux-kernel - Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v64CFoj5gLtZvVu8Hhdy1SAdqLd-pPwT0APh-FYymZnP8Q@mail.gmail.com>
Date:   Fri, 22 Jan 2021 11:09:18 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Hermann Lauer <Hermann.Lauer@....uni-heidelberg.de>
Cc:     Jernej Skrabec <jernej.skrabec@...l.net>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Maxime Ripard <mripard@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: dts: sun7i: a20: bananapro: Fix ethernet node

On Fri, Jan 22, 2021 at 3:54 AM Jernej Škrabec <jernej.skrabec@...l.net> wrote:
>
> Dne četrtek, 21. januar 2021 ob 18:08:36 CET je Hermann Lauer napisal(a):
> > BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high
> > packet loss rates. The realtek phy driver overrides the settings of the
> > pull ups for the delays, so fix this for Banana Pro.
> >
> > Signed-off-by: Hermann Lauer <Hermann.Lauer@...-heidelberg.de>
>
> Much better. Now the only thing missing is "Fixes" tag, which references
> commit which introduced the issue. Probably this will be the commit which
> added ethernet node. This tag is important for deciding which commits should
> be backported to stable releases. Take a look in v1 for M2U fixes tag.
>
> Btw, each version should have changelog under "---" line, so maintainers and
> reviewers know what changed.

The subject line should also be more concise. "Fix ethernet phy-mode" reads
much better than "Fix ethernet node", which could mean a number of things.

ChenYu