linux-kernel - RE: [EXTERNAL] Re: [PATCH net 0/1] net: phy: Fix interrupt mask loss on resume from hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 22 Jan 2021 16:12:49 +0000
From:   "Badel, Laurent" <LaurentBadel@...on.com>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Pavel Machek <pavel@....cz>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: RE: [EXTERNAL]  Re: [PATCH net 0/1] net: phy: Fix interrupt mask loss
 on resume from hibernation

> From: Heiner Kallweit <hkallweit1@...il.com>
> Sent: Friday, January 22, 2021 4:20 PM

> The (optional) software reset is done via soft_reset callback.
> So if the PHY in question needs special treatment after a soft reset,
> why not add it to the soft_reset callback?

Thank you very much for the fast reply. This makes sense, I will 
modify the patch in this direction. 
 
> This sounds to me like a lower level driver (e.g. for GPIO / interrupt
> controller) not resuming properly from hibernation. Supposedly things
> like edge/level high/low/both are stored per interrupt line in a
> register of the interrupt controller, and the controller would have to
> restore the register value on resume from hibernation. You may want to
> have a look at that driver.

I think you are right, the gpio-mxs driver has no PM operations, so 
if it responsible for restoring the interrupt level, no wonder it 
doesn't. This would require implementing the PM ops, which would 
take some additional work, I'll see if I can get around to doing this.
 
Best regards,

Laurent



-----------------------------
Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland 

-----------------------------