linux-kernel - Re: [PATCH 06/20] clk: sifive: fu540-prci: Declare static const variable 'prci_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jan 2021 20:07:23 -0800 (PST)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     lee.jones@...aro.org
CC:     lee.jones@...aro.org, linux-kernel@...r.kernel.org,
        mturquette@...libre.com, sboyd@...nel.org,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Pragnesh.patel@...ive.com, zong.li@...ive.com,
        linux-clk@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject:     Re: [PATCH 06/20] clk: sifive: fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used

On Wed, 20 Jan 2021 01:30:26 PST (-0800), lee.jones@...aro.org wrote:
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/clk/sifive/fu540-prci.h:16:35: warning: ‘prci_clk_fu540’ defined but not used [-Wunused-const-variable=]
>  drivers/clk/sifive/fu540-prci.h:16:35: warning: ‘prci_clk_fu540’ defined but not used [-Wunused-const-variable=]
>
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Paul Walmsley <paul.walmsley@...ive.com>
> Cc: Palmer Dabbelt <palmer@...belt.com>
> Cc: Pragnesh Patel <Pragnesh.patel@...ive.com>
> Cc: Zong Li <zong.li@...ive.com>
> Cc: linux-clk@...r.kernel.org
> Cc: linux-riscv@...ts.infradead.org
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/clk/sifive/fu540-prci.h  | 5 -----
>  drivers/clk/sifive/sifive-prci.c | 5 +++++
>  2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clk/sifive/fu540-prci.h b/drivers/clk/sifive/fu540-prci.h
> index c8271efa7bdc7..c220677dc0108 100644
> --- a/drivers/clk/sifive/fu540-prci.h
> +++ b/drivers/clk/sifive/fu540-prci.h
> @@ -13,9 +13,4 @@
>
>  extern struct __prci_clock __prci_init_clocks_fu540[NUM_CLOCK_FU540];
>
> -static const struct prci_clk_desc prci_clk_fu540 = {
> -	.clks = __prci_init_clocks_fu540,
> -	.num_clks = ARRAY_SIZE(__prci_init_clocks_fu540),
> -};
> -
>  #endif /* __SIFIVE_CLK_FU540_PRCI_H */
> diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c
> index c78b042750e21..1490b01ce6290 100644
> --- a/drivers/clk/sifive/sifive-prci.c
> +++ b/drivers/clk/sifive/sifive-prci.c
> @@ -12,6 +12,11 @@
>  #include "fu540-prci.h"
>  #include "fu740-prci.h"
>
> +static const struct prci_clk_desc prci_clk_fu540 = {
> +	.clks = __prci_init_clocks_fu540,
> +	.num_clks = ARRAY_SIZE(__prci_init_clocks_fu540),
> +};
> +
>  /*
>   * Private functions
>   */

This doesn't look like my sifive-prci.c, so I'm assuming it's against one of
the clock trees and therefor should go in over there.

Acked-by: Palmer Dabbelt <palmerdabbelt@...gle.com>

Thanks!