linux-kernel - Re: [PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

Open Source and information security mailing list archives

Message-ID: <CAAOTY_84OF71QK6M5JT1M5YAFKED_xWVpx8B8t859OsVxE0cfQ@mail.gmail.com>
Date:   Sat, 23 Jan 2021 08:18:06 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc:     Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        DTML <devicetree@...r.kernel.org>, linux-usb@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Min Guo <min.guo@...iatek.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add
 optional clock-names

Hi, Chunfeng:

Chunfeng Yun <chunfeng.yun@...iatek.com> 於 2021年1月22日 週五 下午8:04寫道：
>
> Add an optional "clock-names" property, it's not used to get the clock,
> but some DTS files (e.g. mt8183) provide it.

I think the logic is that we define property in binding document
first, and then write it in device tree. If a property does not exist
in binding document, we should not write it in device tree. So let's
drop this patch and remove clock-names in mt8183.dtsi.

Regards,
Chun-Kuang.

>
> Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> ---
> v2: new patch separated from [3/15] suggested by CK
> ---
>  Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> index 6e4d795f9b02..af6e554c5b69 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> @@ -35,6 +35,10 @@ properties:
>      items:
>        - description: PLL reference clock
>
> +  clock-names:
> +    items:
> +      - const: ref
> +
>    clock-output-names:
>      maxItems: 1
>
> --
> 2.18.0
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives