linux-kernel - Re: [PATCH] watchdog: stop wdd when watchdog hw running in reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210123172609.GA56545@roeck-us.net>
Date:   Sat, 23 Jan 2021 09:26:09 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Qiang Zhao <qiang.zhao@....com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: stop wdd when watchdog hw running in
 reboot_notifier

On Thu, Jan 14, 2021 at 04:26:51PM +0800, Qiang Zhao wrote:
> From: Zhao Qiang <qiang.zhao@....com>
> 
> In watchdog_reboot_notifier, wdd should be stopped when the device
> is in hw_running state
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@....com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/watchdog_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/watchdog_core.c b/drivers/watchdog/watchdog_core.c
> index 861daf4..ec670cc 100644
> --- a/drivers/watchdog/watchdog_core.c
> +++ b/drivers/watchdog/watchdog_core.c
> @@ -154,7 +154,7 @@ static int watchdog_reboot_notifier(struct notifier_block *nb,
>  
>  	wdd = container_of(nb, struct watchdog_device, reboot_nb);
>  	if (code == SYS_DOWN || code == SYS_HALT) {
> -		if (watchdog_active(wdd)) {
> +		if (watchdog_active(wdd) || watchdog_hw_running(wdd)) {
>  			int ret;
>  
>  			ret = wdd->ops->stop(wdd);