linux-kernel - Re: [PATCH v4 2/2] mfd: cros_ec: Add peripheral device charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPUE2uteRNWVYDSeDnadsgXPdsLMMOZTGbJvtzeudC3SP7uMtQ@mail.gmail.com>
Date:   Sat, 23 Jan 2021 10:50:47 -0800
From:   Gwendal Grignou <gwendal@...omium.org>
To:     Daisuke Nojiri <dnojiri@...omium.org>
Cc:     Vincent Palatin <vpalatin@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Sebastian Reichel <sre@...nel.org>,
        Prashant Malani <pmalani@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        Alex Levin <levinale@...gle.com>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Vijay Hiremath <vijay.p.hiremath@...el.com>,
        Yu-Hsuan Hsu <yuhsuan@...omium.org>,
        Ching-Kang Yen <chingkang@...omium.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v4 2/2] mfd: cros_ec: Add peripheral device charger

On Sat, Jan 23, 2021 at 7:54 AM Daisuke Nojiri <dnojiri@...omium.org> wrote:
>
> This patch adds a cell entry for PCHG (Peripheral CHarGer). PCHG is a
> framework managing power supplies for peripheral devices.
>
> Signed-off-by: Daisuke Nojiri <dnojiri@...omium.org>
> Acked-for-MFD-by: Lee Jones <lee.jones@...aro.org>
> ---
> v1->v2
> * None
> v2->v3
> * None
> v3->v4
> * None
> ---
>  drivers/mfd/cros_ec_dev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 6135321592b76c..f3bc1cb6891ba5 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -116,6 +116,7 @@ static const struct mfd_cell cros_ec_platform_cells[] = {
>         { .name = "cros-ec-pd-sysfs" },
>         { .name = "cros-ec-sysfs", },
>         { .name = "cros-ec-pd-update", },
Will not merge upstream, "cros-ec-pd-update" has not been upstreamed yet.
> +       { .name = "cros-ec-pchg", },
In the other patch, you said the driver probe routine will be called
when the feature is supported. For every EC, even older one, these
drivers are always called. If there is a feature flag in the EC (see
ec_feature_code), you can use cros_subdevices instead.
>  };
>
>  static const struct mfd_cell cros_ec_vbc_cells[] = {
> --
> 2.30.0.280.ga3ce27912f-goog
>

Reviewed-by: Gwendal Grignou <gwendal@...omium.org>