lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Jan 2021 20:14:49 -0500 From: Pavel Tatashin <pasha.tatashin@...een.com> To: James Morse <james.morse@....com> Cc: James Morris <jmorris@...ei.org>, Sasha Levin <sashal@...nel.org>, "Eric W. Biederman" <ebiederm@...ssion.com>, kexec mailing list <kexec@...ts.infradead.org>, LKML <linux-kernel@...r.kernel.org>, Jonathan Corbet <corbet@....net>, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, Marc Zyngier <maz@...nel.org>, Vladimir Murzin <vladimir.murzin@....com>, Matthias Brugger <matthias.bgg@...il.com>, Bhupesh Sharma <bhsharma@...hat.com>, linux-mm <linux-mm@...ck.org>, Mark Rutland <mark.rutland@....com>, steve.capper@....com, rfontana@...hat.com, Thomas Gleixner <tglx@...utronix.de>, Selin Dag <selindag@...il.com> Subject: Re: [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types On Wed, Apr 29, 2020 at 1:01 PM James Morse <james.morse@....com> wrote: > > Hi Pavel, > > On 26/03/2020 03:24, Pavel Tatashin wrote: > > Change argument types from unsigned long to a more descriptive > > phys_addr_t. > > For 'entry', which is a physical addresses, sure... > > > diff --git a/arch/arm64/kernel/cpu-reset.h b/arch/arm64/kernel/cpu-reset.h > > index ed50e9587ad8..38cbd4068019 100644 > > --- a/arch/arm64/kernel/cpu-reset.h > > +++ b/arch/arm64/kernel/cpu-reset.h > > @@ -10,17 +10,17 @@ > > > > #include <asm/virt.h> > > > > -void __cpu_soft_restart(unsigned long el2_switch, unsigned long entry, > > - unsigned long arg0, unsigned long arg1, unsigned long arg2); > > > +void __cpu_soft_restart(phys_addr_t el2_switch, phys_addr_t entry, > > + phys_addr_t arg0, phys_addr_t arg1, phys_addr_t arg2); > > This looks weird because its re-using the hyp-stub API, because it might call the hyp-stub > from the idmap. entry is passed in, so this isn't tied to kexec. Without tying it to > kexec, how do you know arg2 is a physical address? > I think it tried to be re-usable because 32bit has more users for this. I will drop this patch. It was intended as a cleanup from suggestions in earlier versions of this series, but I see it is not really needed. Thank you, Pasha
Powered by blists - more mailing lists