linux-kernel - Re: [PATCH v1 0/3] Support building gpio-tegra driver as loadable module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24d46928-8c57-acba-f9cf-49afbe4c983c@gmail.com>
Date:   Sun, 24 Jan 2021 02:56:13 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 0/3] Support building gpio-tegra driver as loadable
 module

24.01.2021 01:50, Linus Walleij пишет:
> On Fri, Jan 22, 2021 at 7:59 PM Dmitry Osipenko <digetx@...il.com> wrote:
> 
>> This small series adds modularization support to the gpio-tegra driver,
>> i.e. driver now could be built as a loadable kernel module.
>>
>> Dmitry Osipenko (3):
>>   gpio: tegra: Use debugfs_create_devm_seqfile()
>>   gpio: tegra: Clean up whitespaces in tegra_gpio_driver
>>   gpio: tegra: Support building driver as a loadable module
> 
> As these three patches clearly make the kernel look better after
> than before:
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> However when we are doing this I would strongly encourage you
> to also make a patch implementing remove() so you can insmod
> rmmod the module at runtime.

The remove() is optional for drivers, it doesn't prevent the rmmod.