linux-kernel - Re: [PATCH 1/4] ubifs: Correctly set inode size in ubifs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Jan 2021 10:35:56 +0800
From:   Zhihao Cheng <chengzhihao1@...wei.com>
To:     Richard Weinberger <richard@....at>,
        <linux-mtd@...ts.infradead.org>
CC:     <david@...ma-star.at>, <linux-kernel@...r.kernel.org>,
        <stable@...r.kernel.org>
Subject: Re: [PATCH 1/4] ubifs: Correctly set inode size in ubifs_link()

在 2021/1/23 5:22, Richard Weinberger 写道:
Reviewed-by: Zhihao Cheng <chengzhihao1@...wei.com>
> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
> index 9a6b8660425a..04912dedca48 100644
> --- a/fs/ubifs/dir.c
> +++ b/fs/ubifs/dir.c
> @@ -693,7 +693,7 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir,
>   	struct inode *inode = d_inode(old_dentry);
>   	struct ubifs_inode *ui = ubifs_inode(inode);
>   	struct ubifs_inode *dir_ui = ubifs_inode(dir);
> -	int err, sz_change = CALC_DENT_SIZE(dentry->d_name.len);
> +	int err, sz_change;
>   	struct ubifs_budget_req req = { .new_dent = 1, .dirtied_ino = 2,
>   				.dirtied_ino_d = ALIGN(ui->data_len, 8) };
>   	struct fscrypt_name nm;
> @@ -731,6 +731,8 @@ static int ubifs_link(struct dentry *old_dentry, struct inode *dir,
>   	if (inode->i_nlink == 0)
>   		ubifs_delete_orphan(c, inode->i_ino);
>   
> +	sz_change = CALC_DENT_SIZE(fname_len(&nm));
> +
>   	inc_nlink(inode);
>   	ihold(inode);
>   	inode->i_ctime = current_time(inode);
>