linux-kernel - Re: [PATCH] scsi_logging: print cdb into new line after opcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1mtx09wpa.fsf@ca-mkp.ca.oracle.com>
Date:   Fri, 22 Jan 2021 22:09:57 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     "Ewan D. Milne" <emilne@...hat.com>
Cc:     Martin Kepplinger <martin.kepplinger@...i.sm>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, dgilbert@...erlog.com,
        bvanassche@....org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi_logging: print cdb into new line after opcode


Ewan,

>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01
>> 00
>> 
>> Print the cdb into a new line in any case, not only when cmd_len is
>> greater than 16. The above example error will then read:
>> 
>> sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28
>> 28 00 01 c0 09 00 00 00 08 00
>
> I'd rather we not change this.

I agree. While the current format is suboptimal, there are lots of
things out there parsing these error messages.

-- 
Martin K. Petersen	Oracle Linux Engineering