linux-kernel - Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6632821.dtBD41K2ms@g550jk>
Date:   Sun, 24 Jan 2021 18:31:34 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     Iskren Chernev <iskren.chernev@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     Andy Gross <agross@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Samuel Pascua <pascua.samuel.14@...il.com>,
        Alexey Minnekhanov <alexeymin@...tmarketos.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
Subject: Re: [PATCH 3/4] ARM: dts: qcom: msm8974-klte: add support for display

Hi Konrad,

On Sonntag, 24. Jänner 2021 16:04:13 CET Konrad Dybcio wrote:
> > +	mdss@...00000 {
> > +		status = "ok";
> > +
> > +		mdp@...00000 {
> > +			status = "ok";
> > +		};
> > +
> > +		dsi@...22800 {
> > +			status = "ok";
> > +
> > +			vdda-supply = <&pma8084_l2>;
> > +			vdd-supply = <&pma8084_l22>;
> > +			vddio-supply = <&pma8084_l12>;
> > +
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +
> > +			ports {
> > +				port@1 {
> > +					endpoint {
> > +						remote-
endpoint = <&panel_in>;
> > +						data-lanes 
= <0 1 2 3>;
> > +					};
> > +				};
> > +			};
> > +
> > +			panel: panel@0 {
> > +				reg = <0>;
> > +				compatible = "samsung,s6e3fa2";
> > +
> > +				pinctrl-names = "default";
> > +				pinctrl-0 = <&panel_pin>;
> > +
> > +				port {
> > +					panel_in: endpoint {
> > +						remote-
endpoint = <&dsi0_out>;
> > +					};
> > +				};
> > +			};
> > +		};
> > +
> > +		dsi-phy@...22a00 {
> > +			status = "ok";
> > +
> > +			vddio-supply = <&pma8084_l12>;
> > +		};
> > +	};
> > 
> >  };
> 
> Please use &label here. If there's none, add them in msm8974.dtsi.
> 

All msm8974 dts(i) files use this style. Deviating from it for this doesn't 
make sense. And yes msm8974 should probably be converted to the newer label 
style (as was done with msm8916 a while ago).

> 
> Konrad

Regards
Luca