linux-kernel - Re: [PATCH v7 6/6] regulator: bd9576: Support error reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202101250202.OpiGYiZP-lkp@intel.com>
Date:   Mon, 25 Jan 2021 02:56:25 +0800
From:   kernel test robot <lkp@...el.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@...il.com>
Cc:     kbuild-all@...ts.01.org, Lee Jones <lee.jones@...aro.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-kernel@...r.kernel.org, linux-power@...rohmeurope.com,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Subject: Re: [PATCH v7 6/6] regulator: bd9576: Support error reporting

Hi Matti,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 7c53f6b671f4aba70ff15e1b05148b10d58c2837]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Support-ROHM-BD9576MUF-and-BD9573MUF-PMICs/20210124-214317
base:    7c53f6b671f4aba70ff15e1b05148b10d58c2837
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a8fb3903668748b6a0b662b462c84825df47cf45
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matti-Vaittinen/Support-ROHM-BD9576MUF-and-BD9573MUF-PMICs/20210124-214317
        git checkout a8fb3903668748b6a0b662b462c84825df47cf45
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/regulator/bd9576-regulator.c:248:6: warning: no previous prototype for 'delayed_enable_irq' [-Wmissing-prototypes]
     248 | void delayed_enable_irq(struct delayed_work *w, int irq)
         |      ^~~~~~~~~~~~~~~~~~


vim +/delayed_enable_irq +248 drivers/regulator/bd9576-regulator.c

   244	
   245	#define BD9576_THERM_IRQ_MASK_TW	BIT(5)
   246	#define BD9576_xVD_IRQ_MASK_VOUTL1	BIT(5)
   247	#define BD9576_UVD_IRQ_MASK_VOUTS1_OCW	BIT(6)
 > 248	void delayed_enable_irq(struct delayed_work *w, int irq)
   249	{
   250		/* keep the "main" IRQ masked for 1 sec */
   251		disable_irq_nosync(irq);
   252		schedule_delayed_work(w, msecs_to_jiffies(IRQS_SILENT_MS));
   253	}
   254	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (58811 bytes)