linux-kernel - Re: [PATCH 1/2] MIPS: jazz: always allow little-endian builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 22 Jan 2021 14:05:55 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Paul Burton <paulburton@...nel.org>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] MIPS: jazz: always allow little-endian builds

On Fri, Jan 22, 2021 at 12:02:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The kernel test robot keeps reporting the same bug when it
> shows up in new files after random unrelated patches:
> 
> In file included from arch/mips/include/uapi/asm/byteorder.h:13,
>                  from arch/mips/include/asm/bitops.h:20,
>                  from include/linux/bitops.h:26,
>                  from include/linux/kernel.h:12,
>                  from include/linux/clk.h:13,
>                  from drivers/base/regmap/regmap-mmio.c:7:
> include/linux/byteorder/big_endian.h:8:2: warning: #warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN [-Wcpp]
>     8 | #warning inconsistent configuration, needs CONFIG_CPU_BIG_ENDIAN
>       |  ^~~~~~~
> drivers/base/regmap/regmap-mmio.c: In function 'regmap_mmio_gen_context':
> >> drivers/base/regmap/regmap-mmio.c:274:2: error: duplicate case value
>   274 |  case REGMAP_ENDIAN_NATIVE:
>       |  ^~~~
> drivers/base/regmap/regmap-mmio.c:246:2: note: previously used here
>   246 |  case REGMAP_ENDIAN_NATIVE:
> 
> The problem is that some randconfig builds end up on the MIPS jazz
> platform with neither CONFIG_CPU_BIG_ENDIAN nor CONFIG_CPU_LITTLE_ENDIAN
> because no specific machine is selected. As it turns out, all jazz
> machines support little-endian kernels, so this can simply be allowed
> globally.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> The configuration used by lkp here showed two other unrelated bugs,
> one of which I'm addressing in another patch. The one I'm not
> addressing is that 32-bit JAZZ with hugepages and 4K pages triggers
> BUILD_BUG_ON(IS_ENABLED(CONFIG_32BIT) && (_PFN_SHIFT > PAGE_SHIFT)).
> ---
>  arch/mips/Kconfig      | 1 +
>  arch/mips/jazz/Kconfig | 3 ---
>  2 files changed, 1 insertion(+), 3 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]