linux-kernel - Re: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <TWJFNQ.UE3BBA1DX3OL@crapouillou.net>
Date:   Sun, 24 Jan 2021 08:36:29 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Qiujun Huang <hqjagain@...il.com>
Cc:     kishon@...com, vkoul@...nel.org, zhouyanjie@...yeetech.com,
        aric.pzqi@...enic.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was
 enabled

Hi, thank you for your patch.


Le sam. 23 janv. 2021 à 23:01, Qiujun Huang <hqjagain@...il.com> a 
écrit :
> We should compile this driver only if we opened PHY_INGENIC_USB.

'opened' -> 'enable'.

> Signed-off-by: Qiujun Huang <hqjagain@...il.com>

You will need to add a Fixes: tag and Cc linux-stable, since the 
problem is already in 5.10.

Cheers,
-Paul

> ---
>  drivers/phy/ingenic/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/ingenic/Makefile 
> b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..a00306651423 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
>  # SPDX-License-Identifier: GPL-2.0
> -obj-y		+= phy-ingenic-usb.o
> +obj-$(PHY_INGENIC_USB)		+= phy-ingenic-usb.o
> --
> 2.25.1
>