linux-kernel - Re: [PATCH next v2 03/17] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1611555708.3905.5.camel@mhfsdcap03>
Date:   Mon, 25 Jan 2021 14:21:48 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     Chun-Kuang Hu <chunkuang.hu@...nel.org>
CC:     Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Min Guo <min.guo@...iatek.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH next v2 03/17] dt-bindings: phy: mediatek: dsi-phy:
 modify compatible dependence

On Sun, 2021-01-24 at 12:56 +0800, Chun-Kuang Hu wrote:
> Hi, Chunfeng:
> 
> Chun-Kuang Hu <chunkuang.hu@...nel.org> 於 2021年1月24日 週日 下午12:47寫道：
> >
> > Hi, Chunfeng:
> >
> > Chunfeng Yun <chunfeng.yun@...iatek.com> 於 2021年1月22日 週五 下午8:04寫道：
> > >
> > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver,
> > > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so changes
> > > the compatible items to make dependence clear.
> >
> > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> 
> Sorry, please remove my reviewed-by tag. We should not define the
> binding document according to the implementation of driver. We define
> the binding document according to the hardware. So the description
> should be like "mt7623-mipi-tx is compatible to mt2701-mipi-tx".
Ok, will make the description clearer

> 
> Regards,
> Chun-Kuang.
> 
> >
> > >
> > > Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> > > Cc: Philipp Zabel <p.zabel@...gutronix.de>
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> > > ---
> > > v2: separate two patches suggested by CK
> > > ---
> > >  .../devicetree/bindings/phy/mediatek,dsi-phy.yaml   | 13 ++++++++-----
> > >  1 file changed, 8 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > > index 71d4acea1f66..6e4d795f9b02 100644
> > > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
> > > @@ -19,11 +19,14 @@ properties:
> > >      pattern: "^dsi-phy@[0-9a-f]+$"
> > >
> > >    compatible:
> > > -    enum:
> > > -      - mediatek,mt2701-mipi-tx
> > > -      - mediatek,mt7623-mipi-tx
> > > -      - mediatek,mt8173-mipi-tx
> > > -      - mediatek,mt8183-mipi-tx
> > > +    oneOf:
> > > +      - items:
> > > +          - enum:
> > > +              - mediatek,mt7623-mipi-tx
> > > +          - const: mediatek,mt2701-mipi-tx
> > > +      - const: mediatek,mt2701-mipi-tx
> > > +      - const: mediatek,mt8173-mipi-tx
> > > +      - const: mediatek,mt8183-mipi-tx
> > >
> > >    reg:
> > >      maxItems: 1
> > > --
> > > 2.18.0