linux-kernel - Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hczxt5ttt.wl-tiwai@suse.de>
Date:   Mon, 25 Jan 2021 09:01:02 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
Cc:     perex@...ex.cz, tiwai@...e.com, kai.vehmanen@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com,
        guennadi.liakhovetski@...ux.intel.com, kai.heng.feng@...onical.com,
        rppt@...nel.org, hui.wang@...onical.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: Assign boolean values to a bool variable

On Mon, 25 Jan 2021 08:17:27 +0100,
Jiapeng Zhong wrote:
> 
> Fix the following coccicheck warnings:
> 
> ./sound/pci/hda/hda_intel.c:2309:3-23: WARNING: Assignment of
> 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>

Thanks, applied now.

But if you have some more similar changes, please try to convert at
once instead of submitting each change infrequently.  It's getting
annoying now, as the change itself hardly helps improving the
readability or code quality in general, although there is no strong
reason to object it.


Takashi