linux-kernel - Re: [STABLE BACKPORT v2 4.4.y, 4.9.y and 4.14.y] compiler.h: Raise minimum version of GCC to 5.1 for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YA7WztCb4OGA6m4S@kroah.com>
Date:   Mon, 25 Jan 2021 15:33:50 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Will Deacon <will@...nel.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Arnd Bergmann <arnd@...nel.org>,
        Nathan Chancellor <natechancellor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Theodore Ts'o <tytso@....edu>,
        Florian Weimer <fweimer@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>
Subject: Re: [STABLE BACKPORT v2 4.4.y, 4.9.y and 4.14.y] compiler.h: Raise
 minimum version of GCC to 5.1 for arm64

On Mon, Jan 25, 2021 at 01:24:25PM +0000, Will Deacon wrote:
> commit dca5244d2f5b94f1809f0c02a549edf41ccd5493 upstream.
> 
> GCC versions >= 4.9 and < 5.1 have been shown to emit memory references
> beyond the stack pointer, resulting in memory corruption if an interrupt
> is taken after the stack pointer has been adjusted but before the
> reference has been executed. This leads to subtle, infrequent data
> corruption such as the EXT4 problems reported by Russell King at the
> link below.
> 
> Life is too short for buggy compilers, so raise the minimum GCC version
> required by arm64 to 5.1.
> 
> Reported-by: Russell King <linux@...linux.org.uk>
> Suggested-by: Arnd Bergmann <arnd@...nel.org>
> Signed-off-by: Will Deacon <will@...nel.org>
> Tested-by: Nathan Chancellor <natechancellor@...il.com>
> Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Reviewed-by: Nathan Chancellor <natechancellor@...il.com>
> Acked-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: <stable@...r.kernel.org> # 4.4.y, 4.9.y and 4.14.y only
> Cc: Theodore Ts'o <tytso@....edu>
> Cc: Florian Weimer <fweimer@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> Cc: Nathan Chancellor <natechancellor@...il.com>
> Cc: Naresh Kamboju <naresh.kamboju@...aro.org>
> Link: https://lore.kernel.org/r/20210105154726.GD1551@shell.armlinux.org.uk
> Link: https://lore.kernel.org/r/20210112224832.10980-1-will@kernel.org
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> [will: backport to 4.4.y/4.9.y/4.14.y; add __clang__ check]
> Link: https://lore.kernel.org/r/CA+G9fYuzE9WMSB7uGjV4gTzK510SHEdJb_UXQCzsQ5MqA=h9SA@mail.gmail.com
> Signed-off-by: Will Deacon <will@...nel.org>
> ---
>  include/linux/compiler-gcc.h | 6 ++++++
>  1 file changed, 6 insertions(+)

Thanks, now queued up, let's try this again :)

greg k-h