linux-kernel - Re: [PATCH v6 0/7] MSFT offloading support for advertisement monitor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Jan 2021 16:09:08 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Archie Pusaka <apusaka@...gle.com>
Cc:     linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        CrosBT Upstreaming <chromeos-bluetooth-upstreaming@...omium.org>,
        Archie Pusaka <apusaka@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v6 0/7] MSFT offloading support for advertisement monitor

Hi Archie,

> This series of patches manages the hardware offloading part of MSFT
> extension API. The full documentation can be accessed by this link:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bluetooth/microsoft-defined-bluetooth-hci-commands-and-events
> 
> Only four of the HCI commands are planned to be implemented:
> HCI_VS_MSFT_Read_Supported_Features (implemented in previous patch),
> HCI_VS_MSFT_LE_Monitor_Advertisement,
> HCI_VS_MSFT_LE_Cancel_Monitor_Advertisement, and
> HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable.
> These are the commands which would be used for advertisement monitor
> feature. Only if the controller supports the MSFT extension would
> these commands be sent. Otherwise, software-based monitoring would be
> performed in the user space instead.
> 
> Thanks in advance for your feedback!
> 
> Archie
> 
> Changes in v6:
> * New patch "advmon offload MSFT interleave scanning integration"
> * New patch "disable advertisement filters during suspend"
> 
> Changes in v5:
> * Discard struct flags on msft_data and use it's members directly
> 
> Changes in v4:
> * Change the logic of merging add_adv_patterns_monitor with rssi
> * Aligning variable declaration on mgmt.h
> * Replacing the usage of BT_DBG with bt_dev_dbg
> 
> Changes in v3:
> * Flips the order of rssi and pattern_count on mgmt struct
> * Fix return type of msft_remove_monitor
> 
> Changes in v2:
> * Add a new opcode instead of modifying an existing one
> * Also implement the new MGMT opcode and merge the functionality with
>  the old one.
> 
> Archie Pusaka (6):
>  Bluetooth: advmon offload MSFT add rssi support
>  Bluetooth: advmon offload MSFT add monitor
>  Bluetooth: advmon offload MSFT remove monitor
>  Bluetooth: advmon offload MSFT handle controller reset
>  Bluetooth: advmon offload MSFT handle filter enablement
>  Bluetooth: advmon offload MSFT interleave scanning integration
> 
> Howard Chung (1):
>  Bluetooth: disable advertisement filters during suspend
> 
> include/net/bluetooth/hci_core.h |  36 ++-
> include/net/bluetooth/mgmt.h     |  16 ++
> net/bluetooth/hci_core.c         | 174 +++++++++---
> net/bluetooth/hci_request.c      |  49 +++-
> net/bluetooth/mgmt.c             | 391 +++++++++++++++++++-------
> net/bluetooth/msft.c             | 460 ++++++++++++++++++++++++++++++-
> net/bluetooth/msft.h             |  30 ++
> 7 files changed, 1015 insertions(+), 141 deletions(-)

all 7 patches have been applied to bluetooth-next tree.

Regards

Marcel