linux-kernel - Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMcCCgTo87HmwexZS696ok16e9s_8gRgFd38uoLP34r7TbAzBg@mail.gmail.com>
Date:   Mon, 25 Jan 2021 10:05:08 -0800
From:   Tom Hebb <tommyhebb@...il.com>
To:     Pali Rohár <pali@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bob Hepple <bob.hepple@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist

On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@...nel.org> wrote:
>
> On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > freezing behavior to the other systems[1] on this blacklist. The issue
> > was exposed by a prior change of mine to automatically load
> > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > this model to the blacklist.
> >
> > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> >
> > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > Cc: stable@...r.kernel.org
> > Reported-by: Bob Hepple <bob.hepple@...il.com>
> > Tested-by: Bob Hepple <bob.hepple@...il.com>
> > Signed-off-by: Thomas Hebb <tommyhebb@...il.com>
> > ---
> >
> >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > index ec448f5f2dc3..73b9db9e3aab 100644
> > --- a/drivers/hwmon/dell-smm-hwmon.c
> > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> >               },
> >       },
> > +     {
> > +             .ident = "Dell XPS 15 L502X",
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
>
> Hello! Are you sure that it is required to completely disable fan
> support? And not only access to fan type label for which is different
> blaclist i8k_blacklist_fan_type_dmi_table?

This is a good question. We didn't try the other list. Bob is the one with the
affected system. Could you try moving the added block of code from
i8k_blacklist_fan_support_dmi_table a few lines up to
i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
remains fixed?

>
> And have you reported this issue to Dell support?
>
> > +             },
> > +     },
> >       { }
> >  };
> >
> > --
> > 2.30.0
> >

(Apologies for the previous HTML copy of this reply, to those directly CCed.)

-Tom