linux-kernel - Re: [PATCH] Bluetooth: btusb: Add a Kconfig option to disable USB wakeup by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 25 Jan 2021 19:32:31 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Max Chou <max.chou@...ltek.com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Bluetooth Kernel Mailing List 
        <linux-bluetooth@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Alex Lu <alex_lu@...lsil.com.cn>,
        Hilda Wu <hildawu@...ltek.com>, kidman@...ltek.com
Subject: Re: [PATCH] Bluetooth: btusb: Add a Kconfig option to disable USB
 wakeup by default

Hi Max,

> For the original commit of 9e45524a011107a73bc2cdde8370c61e82e93a4d,
> wakeup is always disabled for Realtek Bluetooth devices.
> However, there's the capability for Realtek Bluetooth devices to
> apply USB wakeup. Otherwise, there's the better power consumption
> without USB wakeup during suspending.
> In this commit, divide the original commit into two parts.
> 1. Redefine the feature that Realtek devices should be enabled wakeup on
> auto-suspend as BTUSB_WAKEUP_AUTOSUSPEND.
> 2. Add a Kconfig option to switch disable_wakeup for Bluetooth
> USB devices by default as CONFIG_BT_HCIBTUSB_DISABLEWAKEUP.

lets not make this so complicated. Lets just make this work. So define this based on the Realtek hardware that supports it and not just a generic option. If your hardware is broken or works different from revision to revision, then quirk it inside the driver.

Regards

Marcel