linux-kernel - Re: [PATCH] n_tty: fix redirected_tty_write checks after write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Jan 2021 12:03:36 -0800
From:   Sami Tolvanen <samitolvanen@...gle.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] n_tty: fix redirected_tty_write checks after write_iter conversion

On Mon, Jan 25, 2021 at 11:45 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> On Mon, Jan 25, 2021 at 11:27 AM Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> >
> > Obvious ACK from me.
>
> Greg - if you have nothing else lined up in the tty tree, I can take
> this fix directly if it's easier.
>
> And Sami - how did you actually notice? Some lint-like tool, or is
> there something that actually broke from n_tty not handling a
> redirected tty right?

Neither, I noticed this because the conflicting function declarations
broke Clang's Control Flow Integrity checking.

Sami