linux-kernel - Re: hppa64-linux-ld: mm/hugetlb.o(.text+0x50dc): cannot reach printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <428d571c-1f68-7a59-3232-9bb362b51a5b@bell.net>
Date:   Mon, 25 Jan 2021 16:17:50 -0500
From:   John David Anglin <dave.anglin@...l.net>
To:     Helge Deller <deller@....de>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        James Bottomley <James.Bottomley@...senpartnership.com>,
        linux-parisc@...r.kernel.org, kbuild-all@...ts.01.org,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: hppa64-linux-ld: mm/hugetlb.o(.text+0x50dc): cannot reach printk

On 2021-01-25 4:13 p.m., Helge Deller wrote:
> On 1/25/21 10:08 PM, John David Anglin wrote:
>> I would suggest the following for this hunk:
>>
>> +    ldil    L%intr_restore, %r2
>> +    BL    preempt_schedule_irq
>> +    ldo     R%intr_restore(%r2), %r2
>>
>>     ldil    L%intr_restore, %r1
>>     b,l    preempt_schedule_irq,%r2
>>     ldo     R%intr_restore(%r1), %r2
>>
>> On PA 2.0 hardware that gives a 22-bit call.
> "BL" is already using "b,l", see #define in arch/parisc/include/asm/assembly.h
>
> The 22-bit weren't sufficient, that's why I changed it too.
Okay but "b,l" only provides a 22-bit branch with %r2 as link register.  You also need to use %r1 in the ldil and ldo instructions.

Dave

-- 
John David Anglin  dave.anglin@...l.net