linux-kernel - Re: [PATCH] ACPI / APEI: Add is_ghes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <672fad2a-b8aa-25ab-ec0c-900e54f7ee2e@amd.com>
Date:   Mon, 25 Jan 2021 16:42:28 -0600
From:   Terry Bowman <terry.bowman@....com>
To:     Borislav Petkov <bp@...en8.de>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     James Morse <james.morse@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>, Tony Luck <tony.luck@...el.com>,
        Yazen Ghannam <yazen.ghannam@....com>,
        Hanjun Guo <guohanjun@...wei.com>,
        Colin Ian King <colin.king@...onical.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        jon.grimm@....com
Subject: Re: [PATCH] ACPI / APEI: Add is_ghes_type() to identify GHES sources

On 1/25/21 11:14 AM, Borislav Petkov wrote:
> On Mon, Jan 25, 2021 at 05:41:04PM +0100, Rafael J. Wysocki wrote:
>> On Fri, Jan 22, 2021 at 7:05 PM Terry Bowman<terry.bowman@....com>  wrote:
>>> From: Yazen Ghannam<yazen.ghannam@....com>
>>>
>>> Refactor duplicated GHES identity logic into is_ghes_type().
>>>
>>> Signed-off-by: Yazen Ghannam<yazen.ghannam@....com>
>>> Reviewed-by: Robert Richter<rrichter@....com>
>>> Signed-off-by: Terry Bowman<terry.bowman@....com>
>> If Terry was a co-author of the patch, please add a Co-developed-by:
>> tag for him in addition to the s-o-b.  Otherwise the meaning of his
>> s-o-b is unclear.
I will add "co-developed-by" in V2.
>> Boris, James, any objections to the changes below?
>>
>>> ---
>>>   drivers/acpi/apei/hest.c | 12 ++++++++----
>>>   1 file changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
>>> index 6e980fe16772..bd702e0ef339 100644
>>> --- a/drivers/acpi/apei/hest.c
>>> +++ b/drivers/acpi/apei/hest.c
>>> @@ -49,6 +49,12 @@ static const int hest_esrc_len_tab[ACPI_HEST_TYPE_RESERVED] = {
>>>          [ACPI_HEST_TYPE_IA32_DEFERRED_CHECK] = -1,
>>>   };
>>>
>>> +static inline bool is_ghes_type(struct acpi_hest_header *hest_hdr)
>>> +{
>>> +       return hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
>>> +              hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
> I realize that this is supposed to test whether the table point to a
> generic hardware error source but everything in our code pertaining to
> GHES is called, well, "ghes".
>
> So I'd prefer to call that is_generic_error() or so.
Sure, I'll rename is_ghes_type() to is_generic_error() in v2.
> Thx.
>