linux-kernel - Re: [PATCH] media: firmware: qcom_scm: Simplify the calculation of variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Jan 2021 08:07:14 -0600
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
Cc:     agross@...nel.org, p.zabel@...gutronix.de,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: firmware: qcom_scm: Simplify the calculation of
 variables

On Tue 26 Jan 02:52 CST 2021, Jiapeng Zhong wrote:

> Fix the following coccicheck warnings:
> 
> ./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is
> equivalent to !A || B.
> 

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@...ux.alibaba.com>
> ---
>  drivers/firmware/qcom_scm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 7be48c1..c530072 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -321,7 +321,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
>  		.owner = ARM_SMCCC_OWNER_SIP,
>  	};
>  
> -	if (!cpus || (cpus && cpumask_empty(cpus)))
> +	if (!cpus || cpumask_empty(cpus))
>  		return -EINVAL;
>  
>  	for_each_cpu(cpu, cpus) {
> -- 
> 1.8.3.1
>