linux-kernel - Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e4e3e25-e69f-56ee-bff6-4fbf68262b38@gmail.com>
Date:   Tue, 26 Jan 2021 05:25:28 -0800
From:   James Smart <jsmart2021@...il.com>
To:     Tong Zhang <ztong0001@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] scsi: lpfc: Add auto select on IRQ_POLL

On 1/25/2021 4:05 PM, Tong Zhang wrote:
> lpfc depends on irq_poll library, but it is not selected automatically.
> When irq_poll is not selected, compiling it can run into following error
>
> ERROR: modpost: "irq_poll_init" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_sched" [drivers/scsi/lpfc/lpfc.ko] undefined!
> ERROR: modpost: "irq_poll_complete" [drivers/scsi/lpfc/lpfc.ko] undefined!
>
> Signed-off-by: Tong Zhang <ztong0001@...il.com>
> ---
>   drivers/scsi/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 701b61ec76ee..c79ac0731b13 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1159,6 +1159,7 @@ config SCSI_LPFC
>   	depends on NVME_TARGET_FC || NVME_TARGET_FC=n
>   	depends on NVME_FC || NVME_FC=n
>   	select CRC_T10DIF
> +	select IRQ_POLL
>   	help
>             This lpfc driver supports the Emulex LightPulse
>             Family of Fibre Channel PCI host adapters.

Reviewed-by: James Smart <jsmart2021@...il.com>

-- james