linux-kernel - Re: [PATCH 03/12] perf/x86/intel: Add perf core PMU support for Sapphire Rapids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBAq11TjpYj2rAot@hirez.programming.kicks-ass.net>
Date:   Tue, 26 Jan 2021 15:44:39 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     kan.liang@...ux.intel.com
Cc:     acme@...nel.org, mingo@...nel.org, linux-kernel@...r.kernel.org,
        eranian@...gle.com, namhyung@...nel.org, jolsa@...hat.com,
        ak@...ux.intel.com, yao.jin@...ux.intel.com
Subject: Re: [PATCH 03/12] perf/x86/intel: Add perf core PMU support for
 Sapphire Rapids

On Tue, Jan 19, 2021 at 12:38:22PM -0800, kan.liang@...ux.intel.com wrote:
> @@ -3671,6 +3853,31 @@ static int intel_pmu_hw_config(struct perf_event *event)
>  		}
>  	}
>  
> +	/*
> +	 * To retrieve complete Memory Info of the load latency event, an
> +	 * auxiliary event has to be enabled simultaneously. Add a check for
> +	 * the load latency event.
> +	 *
> +	 * In a group, the auxiliary event must be in front of the load latency
> +	 * event. The rule is to simplify the implementation of the check.
> +	 * That's because perf cannot have a complete group at the moment.
> +	 */
> +	if (x86_pmu.flags & PMU_FL_MEM_LOADS_AUX &&
> +	    (event->attr.sample_type & PERF_SAMPLE_DATA_SRC) &&
> +	    is_mem_loads_event(event)) {
> +		struct perf_event *leader = event->group_leader;
> +		struct perf_event *sibling = NULL;
> +
> +		if (!is_mem_loads_aux_event(leader)) {
> +			for_each_sibling_event(sibling, leader) {
> +				if (is_mem_loads_aux_event(sibling))
> +					break;
> +			}
> +			if (list_entry_is_head(sibling, &leader->sibling_list, sibling_list))
> +				return -ENODATA;
> +		}
> +	}
> +
>  	if (!(event->attr.config & ARCH_PERFMON_EVENTSEL_ANY))
>  		return 0;
>  

I have vague memories of this getting mentioned in a call at some point.
Pretend I don't know anything and tell me more.