[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <MWHPR11MB16792D061568C6FA30FA9B908EBC9@MWHPR11MB1679.namprd11.prod.outlook.com>
Date: Tue, 26 Jan 2021 14:47:15 +0000
From: "Gross, Mark" <mark.gross@...el.com>
To: Rob Herring <robh+dt@...nel.org>,
Mark Gross <mgross@...ux.intel.com>
CC: "markgross@...nel.org" <markgross@...nel.org>,
Arnd Bergmann <arnd@...db.de>, Borislav Petkov <bp@...e.de>,
Damien Le Moal <damien.lemoal@....com>,
Dragan Cvetic <dragan.cvetic@...inx.com>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
Jonathan Corbet <corbet@....net>,
Palmer Dabbelt <palmerdabbelt@...gle.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Peng Fan <peng.fan@....com>, Shawn Guo <shawnguo@...nel.org>,
Jassi Brar <jassisinghbrar@...il.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Alessandrelli, Daniele" <daniele.alessandrelli@...el.com>
Subject: RE: [PATCH v3 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox
bindings
> -----Original Message-----
> From: Rob Herring <robh+dt@...nel.org>
> Sent: Tuesday, January 26, 2021 5:45 AM
> To: Mark Gross <mgross@...ux.intel.com>
> Cc: markgross@...nel.org; Arnd Bergmann <arnd@...db.de>; Borislav Petkov
> <bp@...e.de>; Damien Le Moal <damien.lemoal@....com>; Dragan Cvetic
> <dragan.cvetic@...inx.com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Jonathan Corbet <corbet@....net>; Palmer
> Dabbelt <palmerdabbelt@...gle.com>; Paul Walmsley
> <paul.walmsley@...ive.com>; Peng Fan <peng.fan@....com>; Shawn Guo
> <shawnguo@...nel.org>; Jassi Brar <jassisinghbrar@...il.com>; linux-
> kernel@...r.kernel.org; Alessandrelli, Daniele
> <daniele.alessandrelli@...el.com>
> Subject: Re: [PATCH v3 02/34] dt-bindings: mailbox: Add Intel VPU IPC mailbox
> bindings
>
> On Mon, Jan 25, 2021 at 11:40 PM <mgross@...ux.intel.com> wrote:
> >
> > From: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> >
> > Add bindings for the Intel VPU IPC mailbox driver.
>
> Sigh. DT list please so it's in my queue and automated checks run.
I'm sorry about that.
Quick question, should I include the DT-list on just the patches with DT yaml or all of the series as its got DT content?
--mark
>
> > Signed-off-by: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> > ---
> > .../mailbox/intel,vpu-ipc-mailbox.yaml | 69 +++++++++++++++++++
> > MAINTAINERS | 6 ++
> > 2 files changed, 75 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
> > b/Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
> > new file mode 100644
> > index 000000000000..923a6d619a64
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.
> > +++ yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # Copyright
> > +(c) 2020 Intel Corporation %YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/mailbox/intel,vpu-ipc-mailbox.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Intel VPU IPC mailbox
> > +
> > +maintainers:
> > + - Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> > +
> > +description: |
> > + Intel VPU SoCs like Keem Bay have hardware FIFOs to enable
> > +Inter-Processor
> > + Communication (IPC) between the CPU and the VPU.
> > +
> > + Specifically, there is one HW FIFO for the CPU (aka Application
> > + Processor -
> > + AP) and one for the VPU. Each FIFO can hold 128 entries of 32 bits
> > + each. A "FIFO-not-empty" interrupt is raised every time there is at
> > + least a message in the FIFO. The CPU FIFO raises interrupts to the
> > + CPU, while the VPU FIFO raises interrupts to VPU. When the CPU
> > + wants to send a message to the VPU it writes to the VPU FIFO,
> > + similarly, when the VPU want to send a message to the CPU, it writes to the
> CPU FIFO.
> > +
> > + Refer to ./mailbox.txt for generic information about mailbox
> > + device-tree bindings.
> > +
> > +properties:
> > + compatible:
> > + const: intel,vpu-ipc-mailbox
> > +
> > + reg:
> > + items:
> > + - description: The CPU FIFO registers
> > + - description: The VPU FIFO registers
> > +
> > + reg-names:
> > + items:
> > + - const: cpu_fifo
> > + - const: vpu_fifo
> > +
> > + interrupts:
> > + items:
> > + - description: CPU FIFO-not-empty interrupt
> > +
> > + "#mbox-cells":
> > + const: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - interrupts
> > + - "#mbox-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + vpu_ipc_mailbox@...300f0 {
> > + compatible = "intel,vpu-ipc-mailbox";
> > + #mbox-cells = <1>;
> > + reg = <0x203300f0 0x310>,
> > + <0x208200f0 0x310>;
> > + reg-names = "cpu_fifo", "vpu_fifo";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 992fe3b0900a..2b82526a00dc 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9181,6 +9181,12 @@ L: platform-driver-x86@...r.kernel.org
> > S: Maintained
> > F: drivers/platform/x86/intel-vbtn.c
> >
> > +INTEL VPU IPC MAILBOX
> > +M: Daniele Alessandrelli <daniele.alessandrelli@...el.com>
> > +M: Mark Gross <mgross@...ux.intel.com>
> > +S: Supported
> > +F: Documentation/devicetree/bindings/mailbox/intel,vpu-ipc-mailbox.yaml
> > +
> > INTEL WIRELESS 3945ABG/BG, 4965AGN (iwlegacy)
> > M: Stanislaw Gruszka <stf_xl@...pl>
> > L: linux-wireless@...r.kernel.org
> > --
> > 2.17.1
> >
Powered by blists - more mailing lists