linux-kernel - Re: [PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is still valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4ecfaf99f322c752d6422056d4ea94f9b3d962b.camel@kernel.org>
Date:   Tue, 26 Jan 2021 17:29:23 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     peterhuewe@....de, jgg@...pe.ca, stefanb@...ux.vnet.ibm.com,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        p.rosenberger@...bus.com, Lino Sanfilippo <l.sanfilippo@...bus.com>
Subject: Re: [PATCH 3/4] tpm: in tpm2_del_space check if ops pointer is
 still valid

On Sun, 2021-01-24 at 17:47 +0100, Lino Sanfilippo wrote:
> 
> Hi Jarkko,
> 
> On 17.01.21 at 19:13, Jarkko Sakkinen wrote:
> > 
> > I have hard time to believe that any of these patches are based on
> > actual regressions.
> > 
> > /Jarko
> > 
> 
> patch 1 is indeed wrong (I oversaw the action call in case of error),
> so please ignore it.
> 
> However patches 2 and 3 are based on bugs I encountered while working with
> TPM. I am sorry if I did not make the issues clear enough in the patches
> commit messages. Let me try to explain it in more detail:
> 
> The bugs showed up after unloading the TPM chip driver module while one
> process still had the /dev/tpmrm device open.

Please refine the patch set, and we will look into that then.

Put fixes tags and logs where appropriate. Thanks.

/Jarkko